Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow asking for a key of obs when use_raw=True in deprecated _get_{obs,var}_array #176

Merged
merged 1 commit into from
Jul 5, 2019

Conversation

ivirshup
Copy link
Member

@ivirshup ivirshup commented Jul 5, 2019

Part of scverse/scanpy#728 and releasing v0.6.22

This throws an error on master:

import scanpy as sc
pbmc = sc.datasets.pbmc68k_reduced()
sc.pl.scatter(pbmc, "n_genes", "HES1")

It doesn't after this commit.

All this does is fix a backward breaking change. sc.pl.scatter still needs to be fixed so it doesn't use the deprecated function, but this is a little more challenging.

@codecov
Copy link

codecov bot commented Jul 5, 2019

Codecov Report

Merging #176 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #176   +/-   ##
=======================================
  Coverage   78.85%   78.85%           
=======================================
  Files          12       12           
  Lines        2109     2109           
=======================================
  Hits         1663     1663           
  Misses        446      446
Impacted Files Coverage Δ
anndata/core/anndata.py 79.38% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 19bd221...d9383e6. Read the comment docs.

@ivirshup ivirshup merged commit 2fef42a into scverse:master Jul 5, 2019
@ivirshup ivirshup mentioned this pull request Jul 5, 2019
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant