-
Notifications
You must be signed in to change notification settings - Fork 154
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(fix): python debugger dask h5 meta array #1774
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1774 +/- ##
==========================================
- Coverage 87.01% 84.48% -2.53%
==========================================
Files 40 40
Lines 6059 6059
==========================================
- Hits 5272 5119 -153
- Misses 787 940 +153
|
flying-sheep
approved these changes
Nov 22, 2024
meeseeksmachine
pushed a commit
to meeseeksmachine/anndata
that referenced
this pull request
Nov 22, 2024
flying-sheep
pushed a commit
that referenced
this pull request
Nov 22, 2024
Co-authored-by: Ilan Gold <ilanbassgold@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Noticed while using the python debugger - dask sets
block_info
toNone
when run this way, which causes the function to error but settingmeta
(probably a good idea anyway) prevents this.This also drive-by fixes an "internal" bug which did not have an effect downstream, but still noticed. And I added a test (which passes anyway without this change, but still a sensible test).