Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(fix): python debugger dask h5 meta array #1774

Merged
merged 6 commits into from
Nov 22, 2024
Merged

Conversation

ilan-gold
Copy link
Contributor

@ilan-gold ilan-gold commented Nov 20, 2024

Noticed while using the python debugger - dask sets block_info to None when run this way, which causes the function to error but setting meta (probably a good idea anyway) prevents this.

This also drive-by fixes an "internal" bug which did not have an effect downstream, but still noticed. And I added a test (which passes anyway without this change, but still a sensible test).

  • Closes #
  • Tests added
  • Release note added (or unnecessary): does not change runtime behavior

@ilan-gold ilan-gold added this to the 0.11.2 milestone Nov 20, 2024
Copy link

codecov bot commented Nov 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.48%. Comparing base (d61e09c) to head (545393a).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1774      +/-   ##
==========================================
- Coverage   87.01%   84.48%   -2.53%     
==========================================
  Files          40       40              
  Lines        6059     6059              
==========================================
- Hits         5272     5119     -153     
- Misses        787      940     +153     
Files with missing lines Coverage Δ
src/anndata/_io/specs/lazy_methods.py 97.50% <100.00%> (-2.50%) ⬇️

... and 8 files with indirect coverage changes

---- 🚨 Try these New Features:

tests/test_io_elementwise.py Outdated Show resolved Hide resolved
src/anndata/_io/specs/lazy_methods.py Show resolved Hide resolved
@flying-sheep flying-sheep merged commit b4c36af into main Nov 22, 2024
15 checks passed
@flying-sheep flying-sheep deleted the ig/fix_h5_array_read branch November 22, 2024 10:17
meeseeksmachine pushed a commit to meeseeksmachine/anndata that referenced this pull request Nov 22, 2024
flying-sheep pushed a commit that referenced this pull request Nov 22, 2024
Co-authored-by: Ilan Gold <ilanbassgold@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants