Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(fix): allow init without X and correct shape inferred #1841

Merged
merged 7 commits into from
Feb 13, 2025

Conversation

ilan-gold
Copy link
Contributor

@ilan-gold ilan-gold added this to the 0.11.4 milestone Jan 27, 2025
Copy link

codecov bot commented Jan 27, 2025

Codecov Report

Attention: Patch coverage is 90.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 83.82%. Comparing base (8d7beab) to head (c53c689).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
src/anndata/_core/anndata.py 90.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1841      +/-   ##
==========================================
- Coverage   86.13%   83.82%   -2.32%     
==========================================
  Files          41       41              
  Lines        6277     6283       +6     
==========================================
- Hits         5407     5267     -140     
- Misses        870     1016     +146     
Files with missing lines Coverage Δ
src/anndata/_core/anndata.py 82.56% <90.00%> (+0.93%) ⬆️

... and 8 files with indirect coverage changes

Copy link
Member

@flying-sheep flying-sheep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There’s a bug with layers. Please fix and add a test inferring from non-square layers to catch that.

src/anndata/_core/anndata.py Outdated Show resolved Hide resolved
@ilan-gold ilan-gold merged commit 4dc0618 into main Feb 13, 2025
15 checks passed
@ilan-gold ilan-gold deleted the ig/fix_layers_init branch February 13, 2025 13:32
meeseeksmachine pushed a commit to meeseeksmachine/anndata that referenced this pull request Feb 13, 2025
ilan-gold added a commit that referenced this pull request Feb 13, 2025
…ferred (#1857)

Co-authored-by: Ilan Gold <ilanbassgold@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Initializing AnnData without X but with layers errors
2 participants