-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cruft PR workflow #168
Cruft PR workflow #168
Conversation
blocked by astral-sh/ruff#4134 |
A PR has been generated to the instance repo: You can check out the PR to preview your changes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks beautiful!
Now how do we best go about merging this and testing this in a real world setting?
In general, I would suggest that the next release of the cookiecutter template only includes the changes from this PR (i.e. delete sync.yaml
). This makes it easier to communicate to the template users that we switched to a new system and the respective PRs will be easy to review and merge (there shouldn't be any merge conflicts).
Co-authored-by: Gregor Sturm <mail@gregor-sturm.de>
OK, how should we do that? |
merge this PR and cherry-pick it in the Or is there a better way of testing your "on release" action before actually making a release? |
I don’t think so, AFAIK there’s no “mock GitHub” we could send requests to. But I’ll do this: |
Co-authored-by: Gregor Sturm <mail@gregor-sturm.de>
I think we need another release on the |
You’re right! |
* Revert "fix typo (#165)" This reverts commit 5f091ed. * Cruft PR workflow (#168) Co-authored-by: Gregor Sturm <mail@gregor-sturm.de> * Fix `git clone` in cruft PR workflow (#196) * depend on cruft in cruft PRs workflow (#197) * Fix cruft invocation typo (#198) * Use namespaced head in cruft PRs (#199) * Use user.login instead of user.name (#200) * Finish cruft PRs (#201) * Cruft PRs: wait for fork creation (#202) * Another backoff for cruft (#207) * Add retry with backoff also for clone * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> * Update template sync - better logging - check out release tag instead of main - put repo owner in PR branch name to deal with forks * fix tests * fix tests * Make name of forked repos include the original user * debug log * fix artifact upload * Fetch main branch from upstream * Fix get fork * fix clone url * fmt * comment on why pre-commit is a runtime dep * less positional * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Wrap entire command in try/catch * Skip PR if already exists for current version. This allows to re-run the entire action on failures without creating noise in the repos where the update was successful. * Fix log messages * Fix tests * Try fix test * Arming bot: Apply to all repos * Fix global exception handler * Fix global exception handler * Simplify code * Allow maintainer to modify the PR * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Fix logging for existing PRs * Set git default branch in tests --------- Co-authored-by: Philipp A <flying-sheep@web.de> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Derived from https://gist.github.com/grst/7593e7ff965df9a6aeab5c4fbdd796bf
Close #138