Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

n_trees is annoy_n_trees in bbknn 1.5.x #1873

Conversation

pinin4fjords
Copy link
Contributor

Latest BBKNN versions (>=1.5.x) uses annoy_n_trees in place of n_trees, just applying that fix here.

@pinin4fjords pinin4fjords changed the title n_tress is annoy_n_trees in bbknn 1.5.x n_trees is annoy_n_trees in bbknn 1.5.x Jun 15, 2021
@codecov
Copy link

codecov bot commented Jun 15, 2021

Codecov Report

Merging #1873 (f48f234) into master (4dd8de9) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1873   +/-   ##
=======================================
  Coverage   71.22%   71.22%           
=======================================
  Files          92       92           
  Lines       11181    11181           
=======================================
  Hits         7964     7964           
  Misses       3217     3217           
Impacted Files Coverage Δ
scanpy/external/pp/_bbknn.py 58.33% <ø> (ø)

@ktpolanski
Copy link
Contributor

I've already opened a more comprehensive PR for this five days ago, but haven't heard back on it.

@pinin4fjords
Copy link
Contributor Author

Ahh, apologies @ktpolanski , closing now.

@ktpolanski
Copy link
Contributor

All good, thanks for doing this :)

@genecell
Copy link

genecell commented Jul 2, 2021

Hi,

I also met this problem. I am using Scanpy 1.7.2, and could you please suggest which version of BBKNN I should use if I don't want to update Scanpy to 1.8.0.

Thanks,
Min

@ktpolanski
Copy link
Contributor

ktpolanski commented Jul 2, 2021

Two options:

  • bbknn < 1.5.0
  • use bbknn.bbknn() instead of the scanpy wrapper

@genecell
Copy link

genecell commented Jul 2, 2021

Two options:

  • bbknn < 1.5.0
  • use bbknn.bbknn() instead of the scanpy wrapper

Thank you for your rapid reply, bbknn 1.4 works for me (scanpy 1.7.2). The second option is good.
Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants