Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Coerce cell id to str #64

Merged
merged 1 commit into from
Jun 28, 2023
Merged

Coerce cell id to str #64

merged 1 commit into from
Jun 28, 2023

Conversation

melonora
Copy link
Collaborator

When running the script to_zarr.py for the xenium datasets one can run into an error which is due to a string accessor being used while the column cell_id is of type int. This PR fixes the issue by coercing to str.

@codecov-commenter
Copy link

Codecov Report

Merging #64 (f3780ee) into main (f259441) will not change coverage.
The diff coverage is 0.00%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #64   +/-   ##
=======================================
  Coverage   41.96%   41.96%           
=======================================
  Files          16       16           
  Lines         853      853           
=======================================
  Hits          358      358           
  Misses        495      495           
Impacted Files Coverage Δ
src/spatialdata_io/readers/xenium.py 33.33% <0.00%> (ø)

@LucaMarconato LucaMarconato merged commit 9ebe2ba into scverse:main Jun 28, 2023
@LucaMarconato
Copy link
Member

Thanks for the fix!

lucas-diedrich pushed a commit to lucas-diedrich/spatialdata-io that referenced this pull request Nov 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants