Skip to content

Conversation

@timtreis
Copy link
Member

No description provided.

@timtreis timtreis added documentation Improvements or additions to documentation release-added labels Sep 11, 2025
@codecov-commenter
Copy link

codecov-commenter commented Sep 11, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 84.08%. Comparing base (c60c29d) to head (81712c2).
⚠️ Report is 35 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #481      +/-   ##
==========================================
+ Coverage   83.95%   84.08%   +0.12%     
==========================================
  Files           8        8              
  Lines        1839     1841       +2     
==========================================
+ Hits         1544     1548       +4     
+ Misses        295      293       -2     
Files with missing lines Coverage Δ
src/spatialdata_plot/pl/utils.py 78.37% <100.00%> (+0.22%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@timtreis timtreis requested a review from Copilot September 12, 2025 20:56
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR refactors random number generation across the test suite by centralizing it through a standardized function and removes unused RNG variables. It also adds a warning when a specified table doesn't annotate the target element and includes various development environment improvements.

  • Replaced direct RNG instantiation with centralized get_standard_RNG() function for consistent test reproducibility
  • Added warning validation when table_name and color are specified but the table doesn't annotate the element
  • Updated development tooling with pixi configuration and GitHub Actions improvements

Reviewed Changes

Copilot reviewed 12 out of 20 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
tests/conftest.py Replaced global RNG with get_standard_RNG() function to ensure consistent random state initialization
tests/pl/test_*.py Updated all test files to use centralized RNG function and removed unused RNG variables
src/spatialdata_plot/pl/utils.py Added warning when specified table doesn't annotate element and simplified assignment syntax
pyproject.toml Updated development dependencies and added pixi workspace configuration
.github/workflows/test.yaml Migrated to pixi-based testing environment with improved caching

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@timtreis timtreis changed the title Add warning if table_name and color are specified but the table doesn't annotate the element Update CI/CD to use pixi and parallel testing Sep 23, 2025
@timtreis timtreis changed the title Update CI/CD to use pixi and parallel testing Update CI/CD to use pixi and parallel testing; also moving to Python 3.11-3.13 Sep 23, 2025
@timtreis timtreis marked this pull request as draft September 23, 2025 20:32
@timtreis timtreis marked this pull request as ready for review September 23, 2025 20:32
@timtreis timtreis closed this Sep 23, 2025
@timtreis timtreis reopened this Sep 23, 2025
@timtreis timtreis merged commit 31b1ee3 into main Sep 23, 2025
6 checks passed
@timtreis timtreis deleted the bugfix/issue467-no-warning-when-the-manually-specified-table-doesnt-actually-annotate-the-labels-element branch September 23, 2025 21:09
@timtreis timtreis self-assigned this Sep 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation release-changed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

No warning when the manually specified table doesn't actually annotate the labels element

3 participants