Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cleanup format #154

Merged
merged 5 commits into from
Feb 27, 2023
Merged

cleanup format #154

merged 5 commits into from
Feb 27, 2023

Conversation

giovp
Copy link
Member

@giovp giovp commented Feb 24, 2023

addressed some of the points described in #149

  • split format version per element

    • except for images and labels that are grouped together, following ome-zarr format
  • removed @type and replaced it with encoding-type

  • added a test for for shapes format

@giovp
Copy link
Member Author

giovp commented Feb 24, 2023

@ivirshup decided to go for spatialdata-encoding-type because I though:

  • it's a safer option before things settle at ngff side.
  • my understanding is that by registering it in spatialdata, it means that without spatialdata that anndata in the zarr store cannot be read, is that correct?

@codecov
Copy link

codecov bot commented Feb 24, 2023

Codecov Report

Merging #154 (0a6e09d) into main (38c661c) will increase coverage by 0.04%.
The diff coverage is 91.89%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #154      +/-   ##
==========================================
+ Coverage   86.82%   86.86%   +0.04%     
==========================================
  Files          23       23              
  Lines        3377     3389      +12     
==========================================
+ Hits         2932     2944      +12     
  Misses        445      445              
Impacted Files Coverage Δ
spatialdata/_io/format.py 87.61% <89.28%> (+1.47%) ⬆️
spatialdata/_io/read.py 99.36% <100.00%> (ø)
spatialdata/_io/write.py 97.31% <100.00%> (ø)

Copy link
Member

@LucaMarconato LucaMarconato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@ivirshup ivirshup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it means that without spatialdata that anndata in the zarr store cannot be read, is that correct?

Yeah, unless the encoding type was just anndata, or we added the registration in anndata.


Overall looks good to me.

@giovp
Copy link
Member Author

giovp commented Feb 27, 2023

it means that without spatialdata that anndata in the zarr store cannot be read, is that correct?

Yeah, unless the encoding type was just anndata, or we added the registration in anndata.

makes sense, maybe worth it once tables are part of the ngff spec

@giovp giovp merged commit 8724f8a into main Feb 27, 2023
@giovp giovp deleted the format/improve branch February 27, 2023 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants