-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cleanup format #154
cleanup format #154
Conversation
@ivirshup decided to go for
|
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #154 +/- ##
==========================================
+ Coverage 86.82% 86.86% +0.04%
==========================================
Files 23 23
Lines 3377 3389 +12
==========================================
+ Hits 2932 2944 +12
Misses 445 445
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it means that without spatialdata that anndata in the zarr store cannot be read, is that correct?
Yeah, unless the encoding type was just anndata
, or we added the registration in anndata.
Overall looks good to me.
makes sense, maybe worth it once tables are part of the ngff spec |
addressed some of the points described in #149
split format version per element
removed
@type
and replaced it withencoding-type
added a test for for shapes format