-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix/aggregation #271
Fix/aggregation #271
Conversation
@@ -0,0 +1,62 @@ | |||
import contextlib |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file is entirely present in main, I just moved it from tests/test_dataloader/test_datasets.py
to tests/dataloader/test_datasets.py
""" | ||
values_centroids_squares = np.array([[x * 18, 0] for x in range(8)] + [[8 * 18 + 7, 0]] + [[0, 90], [50, 90]]) | ||
values_centroids_circles = np.array([[x * 18, 30] for x in range(8)] + [[8 * 18 + 7, 30]]) | ||
by_centroids_squares = np.array([[119, 15], [100, 90], [150, 90], [210, 15]]) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
New addition: added one extra by
square and one extra by
circle, the rest is identical as before, just moved between files.
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #271 +/- ##
==========================================
+ Coverage 89.85% 89.87% +0.01%
==========================================
Files 36 36
Lines 4386 4404 +18
==========================================
+ Hits 3941 3958 +17
- Misses 445 446 +1
|
fix bug with categories and to_parquet(); add tests
Ready for review @giovp @kevinyamauchi After also this small PR in |
No description provided.