Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed bugs and added tests:
PointsModel.parse()
and the dataframe contains bothx
andanother_x
, andcoordinates[
x] = 'another_x
, then the final parsed dataframe would contain the original columnx
and notanother_x
as expected. Added tests.coordinates.keys()
arex
andy
, but the dataframe contains az
column, thez
column is added to the metadata and theget_axis_names()
would returnx
,y
,z
instead ofx
,y
. Now thez
column is not added. Added tests.np.ndarray
instead. I.e. if the parser receives a 2D array but theannotation
dataframe containsz
, nowz
is not added. Added tests.PointsModels.parse()
for dataframes now takes the paramtercoordinates
as optional. In such a case, ifx
,y
, orx
,y
,z
, are in the dataframe, it is assumed, respectively thatcoordinates
is{'x': 'x', 'y': 'y'}
and{'x': 'x', 'y': 'y, 'z', 'z''}
. This improves the ergonomics of the parser and closesPointsModel
default argument forcoordinates
#228. Added tests.