Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dataloader table names #654

Merged
merged 5 commits into from
Aug 6, 2024
Merged

Conversation

LLehner
Copy link
Member

@LLehner LLehner commented Aug 1, 2024

The ImageTilesDataset class cannot be used if the table you want to work with is not called "table", since there are lines where this name is hard-coded, even though the class allows for a table_name to be specified.

An example where this fails is if you follow this tutorial but specify a different table name when creating the dataset.

This PR replaces instances of "table" with table_name.

Copy link

codecov bot commented Aug 1, 2024

Codecov Report

Attention: Patch coverage is 80.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 91.83%. Comparing base (f9fd885) to head (69c9f34).

Files Patch % Lines
src/spatialdata/dataloader/datasets.py 80.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #654      +/-   ##
==========================================
+ Coverage   89.95%   91.83%   +1.87%     
==========================================
  Files          44       44              
  Lines        6769     6770       +1     
==========================================
+ Hits         6089     6217     +128     
+ Misses        680      553     -127     
Files Coverage Δ
src/spatialdata/dataloader/datasets.py 90.29% <80.00%> (+56.63%) ⬆️

... and 1 file with indirect coverage changes

@LLehner LLehner changed the title Fix dataloader Fix dataloader table names Aug 1, 2024
@LucaMarconato
Copy link
Member

Thanks @LLehner for the contribution. Only minor adjustments were neeed. Merging now and fixing the docs before release.

@LucaMarconato LucaMarconato merged commit 2b50217 into scverse:main Aug 6, 2024
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants