Skip to content

Conversation

@muzarski
Copy link
Contributor

@muzarski muzarski commented Apr 14, 2025

According to documentation, the no_mangle attribute is considered unsafe and compiler emits errors when it's used without unsafe() marker.

See: https://doc.rust-lang.org/edition-guide/rust-2024/unsafe-attributes.html

Pre-review checklist

  • I have split my patch into logically separate commits.
  • All commit messages clearly explain what they change and why.
  • PR description sums up the changes and reasons why they should be introduced.
  • I have implemented Rust unit tests for the features/changes introduced.
  • I have enabled appropriate tests in .github/workflows/build.yml in gtest_filter.
  • I have enabled appropriate tests in .github/workflows/cassandra.yml in gtest_filter.

According to documentation, the `no_mangle` attribute is considered
unsafe and compiler emits errors when it's used without `unsafe()` marker.
@muzarski muzarski requested review from Lorak-mmk and wprzytula and removed request for wprzytula April 14, 2025 14:56
@muzarski muzarski mentioned this pull request Apr 14, 2025
@muzarski muzarski self-assigned this Apr 14, 2025
@muzarski muzarski added this to the 0.4 milestone Apr 14, 2025
@muzarski muzarski merged commit 0e1afec into scylladb:master Apr 14, 2025
12 checks passed
@muzarski muzarski deleted the bump-edition-2024 branch April 14, 2025 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants