Null pointer provided to cass_cluster_set_contact_points should clear the list
#293
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Null pointer should clear the list - there is a test case for this, which I'll enable later in this PR. Notice that `update_comma_delimited_list` method can be reused for whitelist/blacklist configuration - the semantics are exactly the same.
The remaining 4 tests are related to whitelist/blacklist filtering. Will be enabled in a separate PR that implements these features.
muzarski
added
bug
Lorak-mmk
approved these changes
May 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref: #132
As PR title says - currently we throw an error if user provides null pointer. Because of that, one integration was disabled.
Helper method
Notice that
update_comma_delimited_listis aset_filtering()function from d79cbe7. It can be reused for whitelist/blacklist filtering config as well.Integration tests
I enabled 2 out of 6
DisconnectedNullStringApiArgsTeststests:Both of these check whether the driver behaves as expected when null string is provided. Remaining tests will be enabled as a part of #291
Pre-review checklist
[ ] I have implemented Rust unit tests for the features/changes introduced..github/workflows/build.ymlingtest_filter..github/workflows/cassandra.ymlingtest_filter.