types: implement API functions for decimal type #146
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
muzarski
force-pushed
the
decimal_support
branch
from
071a74e to
602ab75
Compare
Lorak-mmk
reviewed
Aug 2, 2024
muzarski
force-pushed
the
decimal_support
branch
from
602ab75 to
22d982b
Compare
Lorak-mmk
approved these changes
Aug 4, 2024
muzarski
force-pushed
the
decimal_support
branch
2 times, most recently
from
e95bf13 to
c09cb71
Compare
|
Rebased on master |
Lorak-mmk
approved these changes
Aug 5, 2024
wprzytula
approved these changes
Aug 5, 2024
Added binding support for decimal type.
Implemented cass_statement_bind_decimal[_by_name[_n]]
Integration tests make use of cass_value_get_bytes function to retrieve varint value from row. This needs to implemented to make these tests pass.
muzarski
force-pushed
the
decimal_support
branch
from
c09cb71 to
9248145
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements following set of API functions related to
decimal/varinttypes:The other way (I think it's preferred, looking at the integration tests) to bind
varintvalues is treating them as bytes (i.e. cass_statement_bind_bytes). The only thing that is missing is to implementcass_value_get_bytes's support for varint type. This PR does that as well. Thanks to this, we can enable both decimal and varint integration test cases.Pre-review checklist
.github/workflows/build.ymlingtest_filter..github/workflows/cassandra.ymlingtest_filter.