cargo: update rust-driver to 0.14 #160
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There were some API breaking changes in the most recent release of rust-driver. These issues were addressed in the commit. NOTE: Changes regarding disabling paging are addressed in a following commit just for better review experience. It requires some changes to the code which would introduce unnecessary noise here.
Since `[Query/PreparedStatement]::disable_paging()` method was removed in 0.14, we need to move this flag to the cpp-rust-driver layer. Based on the value of this flag, we call either `[query/execute]_single_page` or `[query/execute]_unpaged`. By default, all statements/queries have paging disabled (as in cpp-driver).
This is the behaviour of cpp-driver.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the rust-driver dependency to 0.14.
There were some minor API breaking changes such as renaming
SerializeCqltoSerializeValue.The most troublesome matter were paging changes in rust driver. We needed to adjust cpp-rust-driver to new paging API introduced in rust-driver:
BytestoPagingStatePagingStateResponseinCassResultinstead ofBytes.Query/PreparedStatement::disable_paging()methods were removed. As a replacement,query/execute_single_pageandquery/execute_unpagedsession methods were introduced. We needed to adjust the cpp-rust-driver to this change by introducing apaging_enabledflag inCassStatement.Pre-review checklist
[ ] I have enabled appropriate tests in.github/workflows/build.ymlingtest_filter.[ ] I have enabled appropriate tests in.github/workflows/cassandra.ymlingtest_filter.