testing: remove implemented functions from testing_unimplemented.cpp
#161
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
muzarski
force-pushed
the
remove_from_unimplemented
branch
2 times, most recently
from
47cb19d to
cee09f5
Compare
This function is implemented, so it should not be in this file.
This function is implemented, so it should not be in this file. For some reason, during dynamic linking, the "unimplemented" version of this function is taken and some tests fail due to this. The corresponding tests are now enabled in CI.
muzarski
force-pushed
the
remove_from_unimplemented
branch
from
cee09f5 to
9f43fb0
Compare
dkropachev
approved these changes
Sep 6, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pre-review checklist
.github/workflows/build.ymlingtest_filter..github/workflows/cassandra.ymlingtest_filter.