iterator: don't erase the lifetime by using 'static #226
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cpp-driver does not increase the reference count. The lifetime of the iterator is bound to the lifetime of result.
It's more readable (and safe) to have an explicit lifetime instead of lifetime-erased references.
It's more readable and easier to spot where Arc cloning appears.
Lorak-mmk
approved these changes
Mar 11, 2025
wprzytula
approved these changes
Mar 11, 2025
This was referenced Apr 10, 2025
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The iterators are borrowing from different types which are owners of the data. Let's emphasize it and introduce lifetime parameters to iterator types.
As a bonus, I replaced all
.clone()withArc::clone()infuture.rs.Pre-review checklist
[ ] I have implemented Rust unit tests for the features/changes introduced.[ ] I have enabled appropriate tests in.github/workflows/build.ymlingtest_filter.[ ] I have enabled appropriate tests in.github/workflows/cassandra.ymlingtest_filter.