Skip to content

cargo: add "lib" to crate-type list #227

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 11, 2025

Conversation

muzarski
Copy link
Collaborator

@muzarski muzarski commented Mar 11, 2025

It's required to enable the doctests for the crate. They will come in handy during further safety refactor.

I also marked the code snippets from documentation in binding.rs with rust,ignore. They should not be run as doc tests.

Pre-review checklist

  • I have split my patch into logically separate commits.
  • All commit messages clearly explain what they change and why.
  • PR description sums up the changes and reasons why they should be introduced.
  • [ ] I have implemented Rust unit tests for the features/changes introduced.
  • [ ] I have enabled appropriate tests in .github/workflows/build.yml in gtest_filter.
  • [ ] I have enabled appropriate tests in .github/workflows/cassandra.yml in gtest_filter.

@muzarski muzarski self-assigned this Mar 11, 2025
@muzarski muzarski requested review from Lorak-mmk and wprzytula March 11, 2025 13:09
@muzarski muzarski added this to the 0.4 milestone Mar 11, 2025
It's required to enable the doctests for the crate.

I also marked the code snippets from documentation in binding.rs with
`rust,ignore`. They should not be run as doc tests.
@muzarski
Copy link
Collaborator Author

v1.1: changed text to rust,ignore, to preserve syntax highlighting

@muzarski muzarski requested a review from Lorak-mmk March 11, 2025 13:33
@muzarski muzarski merged commit 54264db into scylladb:master Mar 11, 2025
11 checks passed
@muzarski muzarski deleted the lib-crate-type branch March 11, 2025 14:12
@muzarski muzarski mentioned this pull request Apr 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants