Expose driver name/version configuration on cluster config level and change default driver name #228
Conversation
dkropachev
force-pushed
the
dk/change-driver-name
branch
from
81cdaef
to
be56d30
Compare
dkropachev
force-pushed
the
dk/change-driver-name
branch
3 times, most recently
from
ce8b253
to
052af77
Compare
cluster.go
Outdated
| @@ -11,6 +11,8 @@ import ( | |||
| "time" | |||
| ) | |||
|
|
|||
| const defaultDriverName = "ScyllaDB GoLang Driver" | |||
There was a problem hiding this comment.
Isn't "Go" official language name?
There was a problem hiding this comment.
Yes, but it's similarity to the verb makes everybody use golang to avoid confusion, even official repo is named golang/go
There was a problem hiding this comment.
Maybe we should use "gocql" to identify it's coming from this driver.
There is another golang driver and one could use that, so maybe we should differentiate it by name.
There was a problem hiding this comment.
How do we name scylla-go-driver then ?
There was a problem hiding this comment.
I would call it "ScyllaDB gocql Driver".
BTW, how does it appear now in system.clients?
There was a problem hiding this comment.
It's kinda weird start with uppercase and suddently drop to lowercase...
There was a problem hiding this comment.
@roydahan , @sylwiaszunejko join in to vote at #228 (comment)
There was a problem hiding this comment.
@dkropachev lets put aside Scylla-go-driver, I don't know if it's "NextGen" and AFAIC it's not our recommended driver or supported one.
There was a problem hiding this comment.
changed it to ScyllaDB GoCQL Driver
change default driver name
dkropachev
requested review from
mykaul,
sylwiaszunejko,
DanielHe4rt and
roydahan
dkropachev
force-pushed
the
dk/change-driver-name
branch
from
052af77
to
79a6c18
Compare
Part of https://github.com/scylladb/scylla-drivers/issues/7
We want all drivers to report their names uniformly.