Add new API for tracing #247
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I added this as a draft due to the ongoing discussion on what condition in |
sylwiaszunejko
force-pushed
the
new_tracing
branch
from
aa7f8df
to
b16072d
Compare
dkropachev
requested changes
Aug 28, 2024
dkropachev
requested changes
Aug 28, 2024
sylwiaszunejko
force-pushed
the
new_tracing
branch
from
61e5484
to
a1d0b4d
Compare
sylwiaszunejko
force-pushed
the
new_tracing
branch
from
a1d0b4d
to
27ef7ea
Compare
dkropachev
approved these changes
Aug 29, 2024
dkropachev
requested changes
Aug 29, 2024
sylwiaszunejko
force-pushed
the
new_tracing
branch
from
27ef7ea
to
1e5f021
Compare
dkropachev
requested changes
Aug 29, 2024
Reading of tracing info should be done asynchoniusly, otherwise enabling tracing will lead to query processing slow down. Current implementation of Tracer - traceWriter has this flaw and is actually not exactly usefull, it just write custom formatted messages into a buffer. This commit adds new implementation of Tracer - tracer which address that problems.
sylwiaszunejko
force-pushed
the
new_tracing
branch
from
1e5f021
to
a9e3ef0
Compare
dkropachev
approved these changes
Aug 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reading of tracing info should be done asynchronously, otherwise enabling tracing will lead to query processing slow down. Current implementation of Tracer - traceWriter has this flaw and is actually not exactly useful, it just write custom formatted messages into a buffer.
This commit adds new implementation of Tracer - tracer which address that problems.
Fixes: #227