-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add github workflow running jenkins job #255
Conversation
57efde1
to
a9870c9
Compare
89801e4
to
fa8ad66
Compare
c021aaa
to
cdb6f0f
Compare
v2:
Things that still need to be addressed:
|
cdb6f0f
to
a3d9e25
Compare
https://github.com/scylladb/gocql/actions/runs/11157393428/job/31011588519?pr=263 I am not sure why the second workflow gets interrupted even though the timeout has not passed yet and the job was still running when it happened |
e4da434
to
af6c532
Compare
@dkropachev is https://github.com/scylladb-actions/jenkins-client an official location for this action? |
It is not, but it shouldn't matter since it is an GitHub action. |
I'm working on stabilizing another shorter test for CI (1h test that is based on this test). I'm not sure what you mean by "need to manually create new job". I also don't think this mechanism is necessary. IMO the CI should use 2024.1 as Scylla_version and the SCT branch is branch-2024.1. In addition, we can have another CI job if we think is necessary that points to "scylla_version: master:latest". |
Tested the new job for CI with various nemesis_seeds (in order to fix it with a specific one later): https://argus.scylladb.com/tests/scylla-cluster-tests/1adffeeb-28ac-432c-a6f8-8477b70fa557 |
Great, what is the next step for the job ? do you want to merge it ? should we finally merge this PR pointing to a job with temporary sct repo/branch ? |
31a523c
to
6d8d5ca
Compare
I have changed the logic to use https://github.com/scylladb-actions/get-version/tree/main to get scylladb latest version |
|
I was working to add more partitions to the test so the workload will be more balanced across the shards, but now I need to stablize it a bit since the load is higher now. |
6d8d5ca
to
69a8ff9
Compare
@roydahan should we use new test as scylladb/scylla-cluster-tests#9137 is merged? |
This workflow pushes scylla-bench docker image using gocql version from the PR and triggers jenkins job that uses this image of scylla-bench. It uses scylladb-actions/get-version cli to get scylla version
69a8ff9
to
bd19e6e
Compare
It keeps failing on provisioning resources, when I changed the instance type from spot to on_demand it works. |
It's probably a transient issue with spot availability. Another option is to trigger it for now with on_demand. |
Sent scylladb/scylla-cluster-tests#9180 to add the fallback by default. |
This workflow pushes scylla-bench docker image using gocql version from the PR and triggers jenkins job that uses this image of scylla-bench.