Refactor awaitSchemaAgreement logic #256
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dkropachev
requested changes
Sep 5, 2024
sylwiaszunejko
force-pushed
the
refactor_await_schema
branch
from
8e45a42
to
e7f3b46
Compare
dkropachev
requested changes
Sep 6, 2024
sylwiaszunejko
force-pushed
the
refactor_await_schema
branch
from
7be5c3f
to
84d8372
Compare
dkropachev
requested changes
Sep 6, 2024
sylwiaszunejko
force-pushed
the
refactor_await_schema
branch
from
84d8372
to
9ff526d
Compare
dkropachev
approved these changes
Sep 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously due to the wrong re-declarations of one variable error handling logic in
awaitSchemaAgreementwas broken. This code has always had the same result because theerrin the condition was the error declared in the function definition not the one used in the for loop above.https://github.com/scylladb/gocql/blob/master/conn.go#L1879-L1881
This PR fixes error handling as well as refactors some pieces of the code.
Fixes: #70