Fix ErrNoConnections from defaultConnectionPicker.Remove code #257
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
i use this driver to interact with an apache Cassandra cluster : the defaultConnPicker is used
the application queries eventually fail with the error
ErrNoConnections
, without any recoveryall connPicker connections eventually are set to
nil
by handling of sporadic network errors over time:Conn.closeWithError
(code)hostConnPool.HandleError
(code)defaultConnPicker.Remove
(code)the query executor loop over nil connections , and the recovery ( pool filling ) does not occur because the pool is full of connections
the old implementation of hostPool, before connPicker , actually remove the failed connection and shorten the slice of connections
i propose the patch to the upstream (i already patched the fork i use in my production code)