Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add workflow to delete old docker images #269

Merged
merged 1 commit into from
Sep 19, 2024
Merged

Add workflow to delete old docker images #269

merged 1 commit into from
Sep 19, 2024

Conversation

sylwiaszunejko
Copy link
Collaborator

No description provided.

@sylwiaszunejko sylwiaszunejko mentioned this pull request Sep 19, 2024
Closed
sylwiaszunejko
sylwiaszunejko commented Sep 19, 2024
View reviewed changes
.github/workflows/clean_dockerhub_images.yml Outdated
Comment on lines 7 to 8
pull_request:
types: [opened, synchronize, reopened]
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

only for the testing purpose, remove before merging

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please remove it before merging.

@sylwiaszunejko sylwiaszunejko self-assigned this Sep 19, 2024
@sylwiaszunejko sylwiaszunejko force-pushed the gc_docker_image branch 5 times, most recently from 54ffc04 to 3819821 Compare September 19, 2024 10:32
@sylwiaszunejko
Copy link
Collaborator Author

sylwiaszunejko commented Sep 19, 2024 •
edited
Loading

it works, this run successfully removed one of the images https://github.com/scylladb/gocql/actions/runs/10939117200/job/30368694202

@sylwiaszunejko sylwiaszunejko marked this pull request as ready for review September 19, 2024 10:34
dkropachev
dkropachev previously approved these changes Sep 19, 2024
View reviewed changes
.github/workflows/clean_dockerhub_images.yml Outdated
Comment on lines 7 to 8
pull_request:
types: [opened, synchronize, reopened]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please remove it before merging.

@sylwiaszunejko
Copy link
Collaborator Author

@dkropachev what should I put in DELETE_AFTER_DAYS? Now it is set to 4 to have something to remove, but it is probably to small, would 30 days be good?

@dkropachev
Copy link
Collaborator

@dkropachev what should I put in DELETE_AFTER_DAYS? Now it is set to 4 to have something to remove, but it is probably to small, would 30 days be good?

Ah yes, let's set it to 30 days

@sylwiaszunejko
Copy link
Collaborator Author

sylwiaszunejko commented Sep 19, 2024 •
edited
Loading

@dkropachev It needs to be approved again after the push

@sylwiaszunejko sylwiaszunejko merged commit 2be0988 into master Sep 19, 2024
1 check passed
@sylwiaszunejko sylwiaszunejko deleted the gc_docker_image branch September 19, 2024 11:47
@sylwiaszunejko sylwiaszunejko mentioned this pull request Sep 19, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dkropachev dkropachev dkropachev approved these changes

Assignees

@sylwiaszunejko sylwiaszunejko

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sylwiaszunejko @dkropachev