Add marshal tests for varchar, text, blob, ascii, uuid, timeuuid cql types
#285
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
illia-li
changed the title
varchar, text, blob, ascii cql typesvarchar, text, blob, ascii cql types
illia-li
changed the title
varchar, text, blob, ascii cql typesvarchar, text, blob, ascii, uuid, timeuuid cql types
dkropachev
previously approved these changes
Oct 3, 2024
| @@ -105,7 +105,7 @@ func (s PositiveSet) runUnmarshalTest(name string, t *testing.T, f func([]byte, | |||
| err = errors.Join(unmarshalErr, err) | |||
| } | |||
| } else if !equalVals(expected, deReference(result)) { | |||
| err = unequalError{Expected: stringValue(expected), Got: stringValue(result)} | |||
| err = unequalError{Expected: stringValue(expected), Got: stringValue(deReference(result))} | |||
There was a problem hiding this comment.
Why do you dereference got value ?
sylwiaszunejko
previously approved these changes
Oct 3, 2024
|
@illia-li , please rebase |
it`s was made for raze the reference levels between `Expected` and `Got` values
…}) on the printing
illia-li
dismissed stale reviews from sylwiaszunejko and dkropachev
via
c34aacf
illia-li
force-pushed
the
il/add/marshal_tests_texts
branch
from
3c44ae9 to
c34aacf
Compare
Done |
dkropachev
approved these changes
Oct 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.