Start debouncing pool.fill() calls #292
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dkropachev
requested changes
Oct 4, 2024
sylwiaszunejko
force-pushed
the
debounce_fill
branch
3 times, most recently
from
df44974 to
448a423
Compare
dkropachev
requested changes
Oct 7, 2024
sylwiaszunejko
force-pushed
the
debounce_fill
branch
2 times, most recently
from
3f429d6 to
98afaee
Compare
dkropachev
reviewed
Oct 7, 2024
sylwiaszunejko
force-pushed
the
debounce_fill
branch
3 times, most recently
from
25e7813 to
66e7714
Compare
This commit introduces ne package chan_debouncer that implements debouncing login for given fn() and tests it. It is used to ignore requests to call `pool.fill()` if there is already one call scheduled, but not being executed yet.
sylwiaszunejko
force-pushed
the
debounce_fill
branch
from
66e7714 to
0422162
Compare
dkropachev
approved these changes
Oct 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces the mechanism to ignore request to call
pool.fill()if there is already one call scheduled, but not being executed yet.Fixes: #258