Skip to content

Fix gocql.Marshal add the unsetColumn processing #343

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 25, 2024
Merged

Fix gocql.Marshal add the unsetColumn processing #343

merged 1 commit into from
Nov 25, 2024

Conversation

illia-li
Copy link

Changes:

  • fix gocql.Marshal add the unsetColumn processing before the cql types processing

@illia-li illia-li mentioned this pull request Nov 15, 2024
Merged
@dkropachev
Copy link
Collaborator

@illia-li , we should replicate old behavior, since unsetColumn defined in the root, we can't use it there directly, let's guess it from reflect.

@illia-li illia-li force-pushed the il/fix/marshal/unsetColumn branch from 57e824c to e745969 Compare November 24, 2024 22:11
@illia-li illia-li force-pushed the il/fix/marshal/unsetColumn branch from e745969 to 5b34867 Compare November 24, 2024 22:36
@dkropachev dkropachev merged commit 98a2a74 into scylladb:master Nov 25, 2024
2 checks passed
@dkropachev dkropachev mentioned this pull request Nov 25, 2024
Closed
@illia-li illia-li deleted the il/fix/marshal/unsetColumn branch November 25, 2024 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dkropachev dkropachev dkropachev approved these changes

@sylwiaszunejko sylwiaszunejko Awaiting requested review from sylwiaszunejko

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@illia-li @dkropachev