Invalidate tablets of updated keyspace/table on control connection reconnect #364
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
For the keyspace, I invalidate only on changes in StrategyOptions, as that is where the important things for us are (like RF). I'm not sure if there are specific things we should check in updated tables to avoid comparing everything. |
dkropachev
previously approved these changes
Dec 2, 2024
metadata_scylla.go
Outdated
Comment on lines
580
to
584
| if !compareInterfaceMaps(metadata.StrategyOptions, updatedMetadata.StrategyOptions) { | ||
| s.removeTabletsWithKeyspace(keyspaceName) | ||
| } |
There was a problem hiding this comment.
Suggested change
| if !compareInterfaceMaps(metadata.StrategyOptions, updatedMetadata.StrategyOptions) { | |
| s.removeTabletsWithKeyspace(keyspaceName) | |
| } | |
| if !compareInterfaceMaps(metadata.StrategyOptions, updatedMetadata.StrategyOptions) { | |
| s.removeTabletsWithKeyspace(keyspaceName) | |
| continue | |
| } |
sylwiaszunejko
force-pushed
the
invalidate-tablets-data
branch
from
44b8183 to
a8083ac
Compare
dkropachev
approved these changes
Dec 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs: #350