Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add StatementPagesTest #261

Merged

Conversation

Bouncheck
Copy link
Collaborator

Adds a simple test that checks if empty pages are correctly skipped through and all rows are being returned.
Covers #254.

@roydahan
Copy link
Collaborator

roydahan commented Jan 4, 2024

Not sure why I can't re-run CI jobs.

Adds a simple test that checks if empty pages are correctly
skipped through and all rows are being returned.
Covers scylladb#254.
Copy link
Collaborator

@roydahan roydahan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and the test is the exact reproducer as in the issue.

@roydahan
Copy link
Collaborator

roydahan commented Jan 4, 2024

All checks are passing.
@avelanarius please review and merge.

@avelanarius avelanarius merged commit 143ae5f into scylladb:scylla-3.x Jan 5, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants