Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the node name from map field #1039

Merged
merged 1 commit into from
Jun 13, 2019

Conversation

aleksbykov
Copy link
Contributor

PR pre-checks (self review)

  • I followed KISS principle
  • I gave variables/functions meaningful self-explanatory names
  • I didn't leave commented-out/debugging code
  • I didn't copy-paste code
  • I added the relevant backport labels
  • [] New configuration option are added and documented (in sdcm/sct_config.py)
  • [] I have added tests to cover my changes (Infrastructure only - under unit-test/ folder)
  • [] All new and existing unit tests passed (hydra unit-tests)
  • [] I have updated the Readme/doc folder accordingly (if needed)

@aleksbykov
Copy link
Contributor Author

Also, maybe write a script which will go through all results and change this fields to new one?

@roydahan
Copy link
Contributor

Yes, we will need a script to go over the results and change them.
Do you have a sample JSON with the new result?

@aleksbykov
Copy link
Contributor Author

@roy,
Sorry forgot to add to commit desc
Now it will look like this:
"setup_details": {
"cloud_credentials_path": "~/.ssh/support",
"db_type": "scylla",
"run_fullscan": "random, 1",
"cluster_backend": "aws",
"user_prefix": "abykov-test-abykov",
"db_cluster_node_details": {
"sys_info": "Linux ip-172-30-0-148.ec2.internal 5.1.8-1.el7.elrepo.x86_64 #1 SMP Sun Jun 9 08:49:11 EDT 2019 x86_64 x86_64 x86_64 GNU/Linux",
"cpu_model": "Intel(R) Xeon(R) CPU E5-2686 v4 @ 2.30GHz"
},

"nemesis_filter_seeds": true,

@bentsi
Copy link
Contributor

bentsi commented Jun 13, 2019

I am merging this and will create a new task in Trello for change old results to the new format

@bentsi bentsi merged commit 9bcd774 into scylladb:master Jun 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants