Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(show-monitor): unset dashboard.id field for the restored dashboard #4144

Merged
merged 1 commit into from
Nov 22, 2021

Conversation

vponomaryov
Copy link
Contributor

Having 'dashboard.id' field be set we get following error:

Error message {"message":"Dashboard not found","status":"not-found"}

So, unset it to make Grafana understand that we create dashboard from
scratch and not update "existing' one.

PR pre-checks (self review)

  • I followed KISS principle and best practices
  • I didn't leave commented-out/debugging code
  • I added the relevant backport labels
  • New configuration option are added and documented (in sdcm/sct_config.py)
  • I have added tests to cover my changes (Infrastructure only - under unit-test/ folder)
  • All new and existing unit tests passed (CI)
  • I have updated the Readme/doc folder accordingly (if needed)

Having 'dashboard.id' field be set we get following error:

    Error message {"message":"Dashboard not found","status":"not-found"}

So, unset it to make Grafana understand that we create dashboard from
scratch and not update "existing' one.
@bentsi bentsi merged commit 54fe322 into scylladb:master Nov 22, 2021
@roydahan
Copy link
Contributor

I think this PR screwed the dashboard somehow.
I'm running a 200gb-48h longevity and the name of the dashboard is: longevity-twcs-3h:
http://52.51.205.181:3000/d/J1T2FZ57za/longevity-twcs-3h-scylla-per-server-metrics-nemesis-master?orgId=1&from=now-1h&to=now

@vponomaryov
Copy link
Contributor Author

I think this PR screwed the dashboard somehow. I'm running a 200gb-48h longevity and the name of the dashboard is: longevity-twcs-3h: http://52.51.205.181:3000/d/J1T2FZ57za/longevity-twcs-3h-scylla-per-server-metrics-nemesis-master?orgId=1&from=now-1h&to=now

This PR definitely fixed the problem that was 100% reproducible here:
https://jenkins.scylladb.com/view/QA/job/QA-tools/job/hydra-show-monitor/31/console

@roydahan do you really need ID in there?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants