Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(k8s-eks): add mgmt restore CI job #7090

Merged
merged 1 commit into from
Jan 15, 2024

Conversation

vponomaryov
Copy link
Contributor

@vponomaryov vponomaryov commented Jan 12, 2024

Testing

PR pre-checks (self review)

  • I added the relevant backport labels
  • I didn't leave commented-out/debugging code

Reminders

  • Add New configuration option and document them (in sdcm/sct_config.py)
  • Add unit tests to cover my changes (under unit-test/ folder)
  • Update the Readme/doc folder relevent to this change (if needed)

@vponomaryov
Copy link
Contributor Author

vponomaryov commented Jan 12, 2024

@fruch
Copy link
Contributor

fruch commented Jan 15, 2024

@vponomaryov
the restore nemesis works as is ?

@vponomaryov
Copy link
Contributor Author

vponomaryov commented Jan 15, 2024

@vponomaryov the restore nemesis works as is ?

As it is written here:

No, it doesn't work due to the following bug: scylladb/scylla-manager#3679

But it should not disallow us to add this CI job config.

@fruch
Copy link
Contributor

fruch commented Jan 15, 2024

@vponomaryov the restore nemesis works as is ?

As it is written here:

No, it doesn't work due to the following bug: scylladb/scylla-manager#3679

But it should not disallow us to add this CI job config.

Why do we have the client encryption enabled in operator runs ? Isn't that configurable ?

@vponomaryov
Copy link
Contributor Author

@vponomaryov the restore nemesis works as is ?

As it is written here:

No, it doesn't work due to the following bug: scylladb/scylla-manager#3679
But it should not disallow us to add this CI job config.

Why do we have the client encryption enabled in operator runs ? Isn't that configurable ?

It is enabled by default since the following change got merged:

Copy link
Contributor

@fruch fruch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fruch fruch merged commit 829935a into scylladb:master Jan 15, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants