Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(upgrade_test): ignore topology change coordinator errors during upgrades #9352

Merged
merged 1 commit into from
Nov 28, 2024
Merged

fix(upgrade_test): ignore topology change coordinator errors during upgrades #9352

merged 1 commit into from
Nov 28, 2024

Conversation

enaydanov
Copy link
Contributor

@enaydanov enaydanov commented Nov 25, 2024 •
edited
Loading

The error messages reported in scylladb/scylladb#20754 and scylladb/scylladb#20950 can be ignored till a proper fix is merged, because it's mostly a bad UX.

Need to be reverted when scylladb/scylladb#20754 and scylladb/scylladb#20950 will be fixed.

Testing

PR pre-checks (self review)

  • I added the relevant backport labels
  • I didn't leave commented-out/debugging code

Reminders

  • Add New configuration option and document them (in sdcm/sct_config.py)
  • Add unit tests to cover my changes (under unit-test/ folder)
  • Update the Readme/doc folder relevant to this change (if needed)

Fixes #9346

@enaydanov enaydanov added backport/6.1 Need backport to 6.1 backport/6.2 labels Nov 25, 2024
aleksbykov
aleksbykov previously approved these changes Nov 25, 2024
View reviewed changes
Copy link
Contributor

@aleksbykov aleksbykov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@enaydanov enaydanov requested a review from aleksbykov November 25, 2024 11:16
@enaydanov enaydanov marked this pull request as draft November 25, 2024 12:12
@enaydanov
fix(upgrade_test): ignore topology change coordinator errors during u…
f9c14d0 
…pgrades

The error messages reported in scylladb#20754 and scylladb#20950 can be
ignored till a proper fix is merged, because it's mostly a bad UX.
@enaydanov enaydanov marked this pull request as ready for review November 26, 2024 12:28
@enaydanov
Copy link
Contributor Author

@aleksbykov please, review it again.

@enaydanov enaydanov requested a review from fruch November 27, 2024 02:50
@enaydanov
Copy link
Contributor Author

Testing runs passed.

@fruch fruch added the backport/2024.2 Need backport to 2024.2 label Nov 28, 2024
@fruch fruch merged commit 3c8655d into scylladb:master Nov 28, 2024
10 checks passed
@mergify mergify bot mentioned this pull request Nov 28, 2024
Merged
4 tasks
This was referenced Nov 28, 2024
Merged
Merged
@scylladbbot scylladbbot removed the backport/6.1 Need backport to 6.1 label Nov 28, 2024
@scylladbbot scylladbbot added backport/6.1-done Commit backported to 6.1 backport/6.2-done backport/2024.2-done Commit backported to 2024.2 and removed backport/6.2 backport/2024.2 Need backport to 2024.2 labels Nov 28, 2024
@juliayakovlev
Copy link
Contributor

@fruch we should backport this to branch-perf-v15

@fruch
Copy link
Contributor

fruch commented Dec 3, 2024

@fruch we should backport this to branch-perf-v15

o.k. let's do

@mergify mergify bot mentioned this pull request Dec 3, 2024
Merged
4 tasks
@fruch fruch mentioned this pull request Dec 10, 2024
Open
2 tasks
@kbr-scylla kbr-scylla mentioned this pull request Dec 11, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aleksbykov aleksbykov aleksbykov approved these changes

@temichus temichus temichus approved these changes

@roydahan roydahan Awaiting requested review from roydahan

@piodul piodul Awaiting requested review from piodul

@fruch fruch Awaiting requested review from fruch

Assignees

@enaydanov enaydanov

Labels
backport/perf-v15-done backport/6.1-done Commit backported to 6.1 backport/6.2-done backport/2024.2-done Commit backported to 2024.2 promoted-to-master
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Submit a PR to SCT to ignore error message from scylladb/issues/20754 in rolling upgrade
6 participants
@enaydanov @juliayakovlev @fruch @temichus @aleksbykov @scylladbbot