[Backport 2024.2] fix(sct_config): str_or_list_or_eval to better return empty values
#9539
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![mergify[bot]](https://avatars.githubusercontent.com/in/10562?s=60&v=4){kind=small}
in case we got empty envirment variable for on of the config option using `str_or_list_or_eval`, we end up with `['']` which maps to True (python truthiness) in turn it did break azure cleanup logic when `SCT_AZURE_REGION_NAME=` was passed empty, and the cleanup didn't found any resources groups to clean. (cherry picked from commit e680e5f)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
in case we got empty envirment variable for on of the config option using
str_or_list_or_eval, we end up with['']which maps to True (python truthiness)in turn it did break azure cleanup logic when
SCT_AZURE_REGION_NAME=was passed empty, and the cleanup didn't found any resources groups to clean.Testing
PR pre-checks (self review)
backportlabelsReminders
sdcm/sct_config.py)unit-test/folder)(cherry picked from commit e680e5f)
Parent PR: #9537