-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(cache-issues): grant read permissions for sc-dbaas-data-qa account #9541
fix(cache-issues): grant read permissions for sc-dbaas-data-qa account #9541
Conversation
@fruch |
.github/workflows/cache-issues.yaml
Outdated
@@ -4,6 +4,10 @@ on: | |||
- cron: '0 */6 * * *' | |||
workflow_dispatch: | |||
|
|||
env: | |||
CLOUDIUS_SYSTEMS_CANONICAL_ID: 0c2716c5c3e86717000f7af99a8c82c5f776b86179f73d4985de88ceff86a9a4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lets put those into secrets
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't have permission to manager secrets here.
Could you please help with that?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've created secrets with those names
You can push it to the main repo for testing, I think you should have permission for doing that. |
Okay, I'll check |
Since SCT test can be triggered not only from under cloudius-systems, but sc-dbaas-data-qa account (cloud longevity tests), cache-issues job is adjusted to grant read permissions to the uploaded files for this sc-dbaas-data-qa account. Grants for cloudius-systems account should be specified as well, otherwise, the owner will miss these permissions.
8c7f32d
to
77b84ee
Compare
Did a testing here - GH Actions job, created files in test directory. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Since SCT test can be triggered not only from under cloudius-systems, but sc-dbaas-data-qa account (cloud longevity tests), cache-issues job is adjusted to grant read permissions to the uploaded files for this sc-dbaas-data-qa account.
Grants for cloudius-systems account should be specified as well, otherwise, the owner will miss these permissions.
Testing
PR pre-checks (self review)
backport
labels