fix(sct_config): define SCT_AWS_ACCOUNT_ID in SCTConfiguration #9553
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Environmental variable SCT_AWS_ACCOUNT_ID is used in aws_okta.py:
`account_id = os.environ.get('SCT_AWS_ACCOUNT_ID', '797456418907')`
The fact it's not defined in sct_config.py fails SCT test execution
for non-default AWS account, ID of which is passed as env variable:
`ValueError: Unsupported environment variables were used: -
SCT_AWS_ACCOUNT_ID=400694452550`
The described above case is relevant for SCT tests with the cluster
created in Scylla Cloud.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Environmental variable SCT_AWS_ACCOUNT_ID is used in aws_okta.py:
account_id = os.environ.get('SCT_AWS_ACCOUNT_ID', '797456418907')The fact it's not defined in sct_config.py fails SCT test execution for non-default AWS account, ID of which is passed as env variable:
ValueError: Unsupported environment variables were used: - SCT_AWS_ACCOUNT_ID=400694452550The described above case is relevant for SCT tests with the cluster created in Scylla Cloud.
Testing
PR pre-checks (self review)
backportlabels