fix(logcollector): fix remote collect cmd to support non-bash shells #9598
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`>&` redirecting syntax has been replaced by `> file 2>&1` to support shells like sh. Such a shell is a default on Manager node deployed in Cloud. That makes impossible logs collect there. In terms of compatibility, `> file 2>&1` should behave consistently across different systems and shells.
mikliapko
requested review from
karol-kokoszka,
Michal-Leszczynski and
a team
fruch
approved these changes
Dec 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
>&redirecting syntax has been replaced by> file 2>&1to support shells like sh.Such a shell is a default on Manager node deployed in Cloud. That makes impossible logs collection there.
In terms of compatibility,
> file 2>&1should behave consistently across different systems and shells.Testing
Has logs for siren-manager.
Checked that all log files were collected, no regression.
PR pre-checks (self review)
backportlabels