Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport perf-v16] improvement(perf): add validation rules for latency decorator #9604

Merged
merged 1 commit into from
Dec 24, 2024

Conversation

mergify[bot]
Copy link

@mergify mergify bot commented Dec 23, 2024

Added validation rules for results sent by
latency_calculator_decorator to Argus.
Each workload and result name (nemesis, predefined step) may set own rules.

Current rules were created based on existing results - to pass typical good results.

closes: #9237

Testing

PR pre-checks (self review)

  • I added the relevant backport labels
  • I didn't leave commented-out/debugging code

Reminders

  • Add New configuration option and document them (in sdcm/sct_config.py)
  • Add unit tests to cover my changes (under unit-test/ folder)
  • Update the Readme/doc folder relevant to this change (if needed)

(cherry picked from commit bc3552a)

Parent PR: #9295

@mergify mergify bot added the conflicts label Dec 23, 2024
@mergify mergify bot assigned soyacz Dec 23, 2024
Copy link
Author

mergify bot commented Dec 23, 2024

Cherry-pick of bc3552a has failed:

On branch mergify/bp/branch-perf-v16/pr-9295
Your branch is up to date with 'origin/branch-perf-v16'.

You are currently cherry-picking commit bc3552ae.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	new file:   configurations/performance/latency-decorator-error-thresholds-nemesis-ent-tablets.yaml
	new file:   configurations/performance/latency-decorator-error-thresholds-nemesis-ent-vnodes.yaml
	new file:   configurations/performance/latency-decorator-error-thresholds-steps-ent-tablets.yaml
	new file:   configurations/performance/latency-decorator-error-thresholds-steps-ent-vnodes.yaml
	modified:   defaults/test_default.yaml
	modified:   jenkins-pipelines/performance/branch-perf-v15/scylla-enterprise/perf-regression/scylla-enterprise-perf-regression-latency-650gb-with-nemesis-tablets.jenkinsfile
	modified:   jenkins-pipelines/performance/branch-perf-v15/scylla-enterprise/perf-regression/scylla-enterprise-perf-regression-latency-650gb-with-nemesis.jenkinsfile
	modified:   jenkins-pipelines/performance/branch-perf-v15/scylla-enterprise/perf-regression/scylla-enterprise-perf-regression-predefined-throughput-steps-vnodes.jenkinsfile
	modified:   jenkins-pipelines/performance/branch-perf-v16/scylla-enterprise/perf-regression/scylla-enterprise-perf-regression-predefined-throughput-steps-tablets.jenkinsfile
	modified:   jenkins-pipelines/performance/branch-perf-v16/scylla-enterprise/perf-regression/scylla-enterprise-perf-regression-predefined-throughput-steps-vnodes.jenkinsfile
	modified:   jenkins-pipelines/performance/branch-perf-v16/scylla-enterprise/perf-regression/scylla-enterprise-perf-regression-predefined-throughput-steps-write-tablets.jenkinsfile
	modified:   jenkins-pipelines/performance/branch-perf-v16/scylla-enterprise/perf-regression/scylla-enterprise-perf-regression-predefined-throughput-steps-write-vnodes.jenkinsfile
	modified:   sdcm/utils/decorators.py
	modified:   unit_tests/test_argus_results.py

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   docs/configuration_options.md
	both modified:   sdcm/argus_results.py
	both modified:   sdcm/sct_config.py

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

@mergify mergify bot marked this pull request as draft December 23, 2024 09:31
Added validation rules for results sent by
`latency_calculator_decorator` to Argus.
Each workload and result name (nemesis, predefined step) may set own
rules.

Current rules were created based on existing results - to pass typical
good results.

closes: #9237
(cherry picked from commit bc3552a)
@soyacz soyacz force-pushed the mergify/bp/branch-perf-v16/pr-9295 branch from c41599a to 621ca92 Compare December 24, 2024 07:11
@soyacz soyacz removed the conflicts label Dec 24, 2024
@soyacz soyacz marked this pull request as ready for review December 24, 2024 07:11
@soyacz soyacz merged commit edfe941 into branch-perf-v16 Dec 24, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant