Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(manager): update jenkinsfile for Manager Azure tests #9649

Merged

Conversation

mikliapko
Copy link
Contributor

@mikliapko mikliapko commented Jan 3, 2025

Changes:

  • Removed scylla version hardcode for Azure job. The image defined in azure_image_db contains Scylla 5.2.1 is outdated. Moreover, there are no restrictions with passing scylla_version directly. With this change, the Azure job will be executed with Scylla 2024.2 which is default for Manager jobs (if any specific doesn't redefine it).
  • Renamed jenkinsfile to address recent move from Centos-based image for Azure jobs to RHEL-based (Replace out-of-support CentOS distro with RHEL9 for Manager tests on Azure #9631).

Testing

  • Manager Azure job - not related to change failure (fix is here)

PR pre-checks (self review)

  • I added the relevant backport labels
  • I didn't leave commented-out/debugging code

@mikliapko mikliapko added the backport/none Backport is not required label Jan 3, 2025
@mikliapko mikliapko self-assigned this Jan 3, 2025
@mikliapko mikliapko changed the title fix(manager): remove azure_image_db hardcode from azure job jenkinsfile fix(manager): remove azure_image_db parameter from Azure job jenkinsfile Jan 3, 2025
@mikliapko mikliapko force-pushed the mgr-dont-hardcode-scylla-version-for-azure branch from 3ecf423 to 92de089 Compare January 3, 2025 12:52
@mikliapko mikliapko marked this pull request as ready for review January 3, 2025 15:57
@mikliapko mikliapko requested a review from rayakurl as a code owner January 3, 2025 15:57
@mikliapko mikliapko requested review from karol-kokoszka, Michal-Leszczynski and a team and removed request for rayakurl January 3, 2025 15:57
Copy link
Contributor

@soyacz soyacz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like you forgot rename change

Changes:
- Removed scylla version hardcode for Azure job. The image defined in
azure_image_db contains Scylla 5.2.1 which outdated. Moreover, there
are no restrictions with passing scylla_version directly.
- Renamed jenkinsfile to address recent move from Centos-based image
for Azure jobs to RHEL-based (1).

refs:
@mikliapko mikliapko force-pushed the mgr-dont-hardcode-scylla-version-for-azure branch from 92de089 to 6c13a1d Compare January 3, 2025 16:22
@mikliapko mikliapko changed the title fix(manager): remove azure_image_db parameter from Azure job jenkinsfile fix(manager): update jenkinsfile for Manager Azure tests Jan 3, 2025
@mikliapko
Copy link
Contributor Author

looks like you forgot rename change

It's part of the same commit.
It was not obvious judging by commit header. So, reworded it to make transparent.

Copy link
Contributor

@fruch fruch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fruch fruch merged commit 6ae1efe into scylladb:master Jan 6, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport/none Backport is not required promoted-to-master
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants