Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sct_ssh): fix UnboundLocalError in hydra attach-test-sg #9715

Merged
merged 2 commits into from
Jan 8, 2025

Conversation

fruch
Copy link
Contributor

@fruch fruch commented Jan 8, 2025

the new support for Azure we missing some variable definition

and was failing like this:

UnboundLocalError: local variable 'azure_vms' referenced before assignment

this change is setting this variable upfront with empty list

Testing

  • tested locally

PR pre-checks (self review)

  • I added the relevant backport labels
  • I didn't leave commented-out/debugging code

Reminders

  • Add New configuration option and document them (in sdcm/sct_config.py)
  • Add unit tests to cover my changes (under unit-test/ folder)
  • Update the Readme/doc folder relevant to this change (if needed)

the new support for Azure we missing some variable definition

and was failing like this:
```
UnboundLocalError: local variable 'azure_vms' referenced before assignment
```

this change is setting this variable upfront with empty list
@fruch fruch added the backport/none Backport is not required label Jan 8, 2025
those test are spin a cluster with docker
they should be part of the integration suite
@fruch fruch merged commit e2348d9 into scylladb:master Jan 8, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport/none Backport is not required promoted-to-master
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants