feature(BaseMonitorSet): Implement monitoring template #9855
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k0machi
force-pushed
the
monitoring-improved-dash-logic
branch
4 times, most recently
from
5f70e7b to
9b4018c
Compare
|
Demo:
One more thing that's missing are previously available template variables for event filtering - I'll add them soon. |
soyacz
reviewed
Jan 20, 2025
|
@k0machi new branch |
k0machi
force-pushed
the
monitoring-improved-dash-logic
branch
6 times, most recently
from
448e001 to
a6f5dac
Compare
|
Added annotations, template variables for event types, added logic to change default values (currently just hardcoded to change the |
|
This run has the updated dashboard, monitoring node is set to |
This commit adds a new templating mechanism for monitoring dashboards, allowing SCT to be in sync with changes in scylla-monitoring repo, by first separating SCT metrics into a separate file, and then injecting them into the overview template on the monitoring node, then regenerating said template. This allows monitoring dashboard to always be up to date with regards to changes on the monitoring side. Fixes scylladb/qa-tasks#1444
k0machi
force-pushed
the
monitoring-improved-dash-logic
branch
from
a6f5dac to
9eeebf4
Compare
|
requests served per instance shows whole numbers (like 30000 instead of 30k) and miss unit (ops/s) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds a new templating mechanism for monitoring dashboards,
allowing SCT to be in sync with changes in scylla-monitoring repo, by
first separating SCT metrics into a separate file, and then injecting
them into the overview template on the monitoring node, then
regenerating said template. This allows monitoring dashboard to always
be up to date with regards to changes on the monitoring side.
Fixes scylladb/qa-tasks#1444
Testing
PR pre-checks (self review)
backportlabelsReminders
sdcm/sct_config.py)unit-test/folder)