[Backport 6.1] fix(unit-tests): stop triggering health checks in longevity unit test #9892
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The 'test_longevity.py::test_test_user_batch_custom_time' unit test uses the 'test-cases/scale/longevity-5000-tables.yaml' config file for running a short longevity test which triggers a nemesis. If health checks are enabled then the "nemesis call" runs much longer while health checks are completed 2 times - before and after the nemesis. And while it is ongoing the nemesis lock gets held. And the problem with it is that it runs even after finish of this test. So, any another unit test which tries to get a nemesis lock will stumble upon a held lock for 10+ minutes. It started happening after the merge of the PR [1] which enabled health checks in the mentioned config file. The affected test is following: - test_nemesis.py::test_list_nemesis_of_added_disrupt_methods Alphabetically it runs after the 'test_longevity.py::test_test_user_batch_custom_time' one. So, disable health checks to avoid side-effects and doing redundant stuff which were not planned when the test was written. [1] scylladb#9843 (cherry picked from commit a78d65f)
|
@vponomaryov - This PR has conflicts, therefore it was moved to |
|
Test which required fixing is just absent here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
test_longevity.py::test_test_user_batch_custom_timeunit test usesthe
test-cases/scale/longevity-5000-tables.yamlconfig file for runninga short longevity test which triggers a nemesis.
If health checks are enabled then the
nemesis callruns much longer while health checksare completed 2 times - before and after the nemesis.
And while it is ongoing the nemesis lock gets held.
And the problem with it is that it runs even after finish of this test.
So, any another unit test which tries to get a nemesis lock will stumble upon a held lock for 10+ minutes.
It started happening after the merge of the PR (#9843) which enabled health checks in the mentioned config file.
The affected test is following:
test_nemesis.py::test_list_nemesis_of_added_disrupt_methodsAlphabetically it runs after the
test_longevity.py::test_test_user_batch_custom_timeone.So, disable health checks to avoid side-effects and doing redundant stuff which were not planned when the test was written.
Testing
PR pre-checks (self review)
backportlabelsReminders
Add New configuration option and document them (in
sdcm/sct_config.py)Add unit tests to cover my changes (under
unit-test/folder)Update the Readme/doc folder relevant to this change (if needed)
(cherry picked from commit a78d65f)
Parent PR: #9888