-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(performance): add sleep after warm-up #9922
Conversation
Can you share a graph from a run using this code, to see if 2 min is enough time to be able to clearly see warmup doesn't have affect on the main load |
https://argus.scylladb.com/tests/scylla-cluster-tests/9df777c1-3b2a-42ed-8846-dd7559d5efd0 This run (with tablets) with sleep 120 sec after warm-up and before 150K step. the latency is 1.75ms
|
5b5ce35
to
a8bb90e
Compare
https://argus.scylladb.com/tests/scylla-cluster-tests/803ec3ab-91ec-441a-b324-f45b6cb6ba1c This run (with tablets) with sleep 240 sec after warm-up and before 150K step. The latency is 0.48
|
Add 4 minutes sleep after warm-up and before step start in predefined steps performnace test. This is for let to all background processes to finish. It may have the impact especially in tablet test - to complete tablets rebuild Fixes: scylladb#9852
a8bb90e
to
94f988a
Compare
Let's stop wasting more money on runs. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Add 2 minutes sleep after warm-up and before step start in predefined steps performnace test. This is for let to all background processes to finish. It may have the impact especially in tablet test - to complete tablets rebuild
Fixes: #9852
Testing
PR pre-checks (self review)
backport
labelsReminders
sdcm/sct_config.py
)unit-test/
folder)