Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sct_config): change type of perf_gradual_ params #9927

Merged

Conversation

juliayakovlev
Copy link
Contributor

@juliayakovlev juliayakovlev commented Jan 28, 2025

The parameters 'perf_gradual_threads' and 'perf_gradual_throttle_steps' are defined with type 'dict'. It prevents dynamicaly changing them in the 'extra_environment_variables' parameter in Jenkins job (if we want to change them while running job, without push commit).
Changing the type to 'dict_or_str' allow us to change those params dynamically

Testing

The 'perf_gradual_threads' and 'perf_gradual_throttle_steps' values are according to extra_environment_variables and config validation step did not fail

Screenshot from 2025-01-28 11-19-45

PR pre-checks (self review)

  • I added the relevant backport labels
  • I didn't leave commented-out/debugging code

Reminders

  • Add New configuration option and document them (in sdcm/sct_config.py)
  • Add unit tests to cover my changes (under unit-test/ folder)
  • Update the Readme/doc folder relevant to this change (if needed)

The parameters 'perf_gradual_threads' and 'perf_gradual_throttle_steps' are defined
with type 'dict'. It prevents dynamicaly changing them in the
'extra_environment_variables' parameter in Jenkins job (if we want to change them
while running job, without push commit).
Changing the type to 'dict_or_str' allow us to change those params dynamically
@juliayakovlev juliayakovlev requested a review from fruch January 28, 2025 08:39
@juliayakovlev juliayakovlev marked this pull request as ready for review January 28, 2025 09:21
Copy link
Contributor

@fruch fruch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fruch fruch requested a review from a team January 28, 2025 09:45
Copy link
Contributor

@soyacz soyacz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@soyacz soyacz merged commit a4dbef2 into scylladb:master Jan 29, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants