-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Scylla manager setting intensity incorrectly when intensity is between 0 and 1 #3665
Comments
Michal-Leszczynski
added a commit
that referenced
this issue
Jan 15, 2024
There are still some bugs (one described in the issue below) regarding using float intensity. In order to get rid of them, we should only tolerate float intensity at the entrypoint, but completely remove it from SM repair internals (both in service and progress display). We keep float intensity in task properties and in swagger endpoint parameters, but we convert it to int intensity as a first thing in internals, which happens in: - GetTarget (from task properties) - sctool repair control endpoint (from query param) Fixes #3665
Michal-Leszczynski
added a commit
that referenced
this issue
Jan 16, 2024
There are still some bugs (one described in the issue below) regarding using float intensity. In order to get rid of them, we should only tolerate float intensity at the entrypoint, but completely remove it from SM repair internals (both in service and progress display). We keep float intensity in task properties and in swagger endpoint parameters, but we convert it to int intensity as a first thing in internals, which happens in: - GetTarget (from task properties) - sctool repair control endpoint (from query param) Fixes #3665
Michal-Leszczynski
added a commit
that referenced
this issue
Jan 17, 2024
There are still some bugs (one described in the issue below) regarding using float intensity. In order to get rid of them, we should only tolerate float intensity at the entrypoint, but completely remove it from SM repair internals (both in service and progress display). We keep float intensity in task properties and in swagger endpoint parameters, but we convert it to int intensity as a first thing in internals, which happens in: - GetTarget (from task properties) - sctool repair control endpoint (from query param) Fixes #3665
karol-kokoszka
pushed a commit
that referenced
this issue
Feb 22, 2024
There are still some bugs (one described in the issue below) regarding using float intensity. In order to get rid of them, we should only tolerate float intensity at the entrypoint, but completely remove it from SM repair internals (both in service and progress display). We keep float intensity in task properties and in swagger endpoint parameters, but we convert it to int intensity as a first thing in internals, which happens in: - GetTarget (from task properties) - sctool repair control endpoint (from query param) Fixes #3665
karol-kokoszka
pushed a commit
that referenced
this issue
Feb 26, 2024
There are still some bugs (one described in the issue below) regarding using float intensity. In order to get rid of them, we should only tolerate float intensity at the entrypoint, but completely remove it from SM repair internals (both in service and progress display). We keep float intensity in task properties and in swagger endpoint parameters, but we convert it to int intensity as a first thing in internals, which happens in: - GetTarget (from task properties) - sctool repair control endpoint (from query param) Fixes #3665
karol-kokoszka
pushed a commit
that referenced
this issue
Feb 26, 2024
There are still some bugs (one described in the issue below) regarding using float intensity. In order to get rid of them, we should only tolerate float intensity at the entrypoint, but completely remove it from SM repair internals (both in service and progress display). We keep float intensity in task properties and in swagger endpoint parameters, but we convert it to int intensity as a first thing in internals, which happens in: - GetTarget (from task properties) - sctool repair control endpoint (from query param) Fixes #3665
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Ghost issue, the real one is here https://github.com/scylladb/scylla-enterprise/issues/3640
The text was updated successfully, but these errors were encountered: