Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unstable master builds versioning issue #3944

Closed
mikliapko opened this issue Jul 26, 2024 · 5 comments
Closed

Unstable master builds versioning issue #3944

mikliapko opened this issue Jul 26, 2024 · 5 comments
Assignees
@yaronkaikov
Labels
ci

Comments

@mikliapko
Copy link

The version of unstable master builds contains invalid data about date and commit hash.

ubuntu@manager-regression-mikita-monitor-node-459da13b-1:~$ apt-cache policy scylla-manager-server
scylla-manager-server:
  Installed: 3.3.0~0.20240707.8f6f1c0b8-SNAPSHOT
  Candidate: 3.3.0~0.20240707.8f6f1c0b8-SNAPSHOT
  Version table:
 *** 3.3.0~0.20240707.8f6f1c0b8-SNAPSHOT 500
        500 https://downloads.scylladb.com/manager/deb/unstable/unified-deb/master/2024-07-24T21:54:57Z stable/main amd64 Packages
        100 /var/lib/dpkg/status

For the example above, the build was created at 2024-07-24T21:54:57 but it has wrong:

  • version 3.3.0~0.20240707.8f6f1c0b8-SNAPSHOT;
  • hash 8f6f1c0 which, at the moment of testing, is the latest commit to branch-3.3.

Build.txt file content for this build:

timestamp: 2024-07-24T21:54:57Z
jenkins-job-path: manager-master/manager-build
jenkins-job-number: 737
url-id: 2024-07-24T21:54:57Z
manager-build-sha: 50ad87c987959fd921d8350be88a5337685daf90
manager-version: 3.4.dev
manager-release: 0.20240724.50ad87c98
centos-rpm-repo-url: downloads.scylladb.com/manager/rpm/unstable/centos/master/2024-07-24T21:54:57Z
centos-rpm-repo-file-url: downloads.scylladb.com/manager/rpm/unstable/centos/master/2024-07-24T21:54:57Z/scylla-manager.repo
unified-deb-repo-url: downloads.scylladb.com/manager/deb/unstable/unified-deb/master/2024-07-24T21:54:57Z
unified-deb-repo-file-url: downloads.scylladb.com/manager/deb/unstable/unified-deb/master/2024-07-24T21:54:57Z/scylla-manager.list
reloc-pack-url: downloads.scylladb.com/manager/relocatable/unstable/master/2024-07-24T21:54:57Z
reloc-pack-file-url: https://downloads.scylladb.com/manager/relocatable/unstable/master/2024-07-24T21:54:57Z/scylla-manager_3.3.0-0.20240707.8f6f1c0b8-SNAPSHOT_linux_x86_64.tar.gz
scylla-manager-image-name: scylla-manager:3.4.dev-0.20240724.50ad87c98
scylla-manager-agent-image-name: scylla-manager-agent:3.4.dev-0.20240724.50ad87c98
@mikliapko
Copy link
Author

@yaronkaikov Could you please take a look?

@yaronkaikov yaronkaikov self-assigned this Aug 22, 2024
@yaronkaikov
Copy link
Collaborator

@mikliapko will send a fix today

yaronkaikov added a commit to yaronkaikov/scylla-manager that referenced this issue Aug 22, 2024
@yaronkaikov
Makefile: Set tags also during snapshot builds
cb10ca2 
Today we have a complete mixup with the tags, causing an override during
builds. To avoid it, we should set a tag for each build (master or
release)

Refs: scylladb#3944

The main fix for this issue will be from Scylla-pkg side
@yaronkaikov yaronkaikov mentioned this issue Aug 22, 2024
Merged
karol-kokoszka pushed a commit that referenced this issue Aug 22, 2024
@yaronkaikov @karol-kokoszka
Makefile: Set tags also during snapshot builds
0ad5692 
Today we have a complete mixup with the tags, causing an override during
builds. To avoid it, we should set a tag for each build (master or
release)

Refs: #3944

The main fix for this issue will be from Scylla-pkg side
yaronkaikov added a commit that referenced this issue Aug 22, 2024
@yaronkaikov
Makefile: Set tags also during snapshot builds
a69f103 
Today we have a complete mixup with the tags, causing an override during
builds. To avoid it, we should set a tag for each build (master or
release)

Refs: #3944

The main fix for this issue will be from Scylla-pkg side

(cherry picked from commit 0ad5692)
@yaronkaikov yaronkaikov mentioned this issue Aug 22, 2024
Merged
karol-kokoszka pushed a commit that referenced this issue Aug 22, 2024
@yaronkaikov @karol-kokoszka
Makefile: Set tags also during snapshot builds
434bd80 
Today we have a complete mixup with the tags, causing an override during
builds. To avoid it, we should set a tag for each build (master or
release)

Refs: #3944

The main fix for this issue will be from Scylla-pkg side

(cherry picked from commit 0ad5692)
@mikliapko
Copy link
Author

The latest build from master has the version 3.4.0-dev
https://downloads.scylladb.com/manager/relocatable/unstable/master/2024-08-22T21%3A55%3A14Z/
image

I suppose it should be something like 3.3.2-dev
@yaronkaikov @Annamikhlin

@yaronkaikov
Copy link
Collaborator

@mikliapko No, master is using the next major version so it is ok to be 3.4.0-dev

@mikliapko
Copy link
Author

@mikliapko No, master is using the next major version so it is ok to be 3.4.0-dev

okay, good to know, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yaronkaikov yaronkaikov

Labels
ci
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@yaronkaikov @mikliapko