Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(healtcheck): respect force-tls-disabled and force-non-ssl-session-port cluster properties #3715

Merged

Conversation

karol-kokoszka
Copy link
Collaborator

Closes #3714


Please make sure that:

  • Code is split to commits that address a single change
  • Commit messages are informative
  • Commit titles have module prefix
  • Commit titles have issue nr. suffix

@Michal-Leszczynski
Copy link
Collaborator

It looks like the tests are broken.

@karol-kokoszka
Copy link
Collaborator Author

It looks like the tests are broken.

It failed on pulling minio image. Re-running the tests.

Pulling minio (minio/minio:RELEASE.2022-10-24T18-35-07Z)...
Get "https://registry-1.docker.io/v2/minio/minio/manifests/sha256:f9576903f19d53b446e362af1ff40623ec1ed5361870e51bd23b7cbcfc9e82e7": read tcp 10.1.0.224:50120->54.196.99.49:443: read: connection reset by peer

@Michal-Leszczynski
Copy link
Collaborator

Returning an error instead of timeout when cluster requires TLS certs and --force-tls-disabled=false still makes sense, so it should be included in the fix for this issue.

Is this addressed in this PR as well?

@karol-kokoszka karol-kokoszka force-pushed the kk/healthcheck-to-follow-general-session-create-logic branch from 6a11ea1 to ebbcef8 Compare February 15, 2024 14:05
@karol-kokoszka
Copy link
Collaborator Author

Is this addressed in this PR as well?

Yes, it's addressed.

@karol-kokoszka karol-kokoszka force-pushed the kk/healthcheck-to-follow-general-session-create-logic branch from ebbcef8 to 8ae3f01 Compare February 15, 2024 15:59
pkg/service/healthcheck/service.go Show resolved Hide resolved
pkg/service/cluster/service.go Show resolved Hide resolved
pkg/service/healthcheck/service.go Show resolved Hide resolved
pkg/service/healthcheck/service.go Show resolved Hide resolved
Copy link
Collaborator

@Michal-Leszczynski Michal-Leszczynski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@karol-kokoszka karol-kokoszka merged commit 7eb7458 into master Feb 21, 2024
77 of 81 checks passed
@karol-kokoszka karol-kokoszka deleted the kk/healthcheck-to-follow-general-session-create-logic branch February 21, 2024 09:55
This was referenced Feb 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix SM cql ping dial logic
2 participants