feat(aws): support for IMDSv2 on setting bucket region #3735
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karol-kokoszka
force-pushed
the
support_for_imdsv2
branch
from
eb30169 to
80b8b09
Compare
karol-kokoszka
force-pushed
the
support_for_imdsv2
branch
from
80b8b09 to
acdc98f
Compare
karol-kokoszka
force-pushed
the
support_for_imdsv2
branch
from
acdc98f to
bf05a9a
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3691
This PR adds support for IMDSv2 instance region retrieval.
Scylla Manager Agent is using IMDS endpoint to get the instance metadata when configuring the RClone region used to write/read data from the S3 bucket.
It happens when the
s3.regionproperty is not configured inscylla-manager-agent.yamlconfig file.If
s3.regionis defined, it takes precedence over the IMDS.IMDSv2 requires to obtain the session token before calling to get the instance metadata. If the session token call fails, SM will fallback to IMDSv1 and just not include token into the request.
Please make sure that: