Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(restore): post-restore repair to use max intensity and parallel #3832

Merged

Conversation

karol-kokoszka
Copy link
Collaborator

Fixes #3823
Fixes #3542


Please make sure that:

  • Code is split to commits that address a single change
  • Commit messages are informative
  • Commit titles have module prefix
  • Commit titles have issue nr. suffix

@Michal-Leszczynski
Copy link
Collaborator

The reason for repair test failure: #3834.

@Michal-Leszczynski
Copy link
Collaborator

I'm fine with this change and I actually created identical PR in the past that was rejected because this comment. Did we validate that sctool repair control works on restore repair as intended? Or maybe this change should be introduced only alongside #3666?

@karol-kokoszka
Copy link
Collaborator Author

Right, would be good to have the repair control available for this post-restore.
Let's discuss on grooming.

@karol-kokoszka
Copy link
Collaborator Author

@Michal-Leszczynski did you have a chance to check if repair control works when the post-restore repair is on-going ?

@karol-kokoszka
Copy link
Collaborator Author

OK, it is updating the port-restore repair.

@karol-kokoszka karol-kokoszka merged commit 31d8383 into master May 9, 2024
50 of 56 checks passed
@karol-kokoszka karol-kokoszka deleted the post-restore-repair-with-max-intensity-and-parallel branch May 9, 2024 08:27
@karol-kokoszka karol-kokoszka mentioned this pull request May 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants