Bump go to 1.23 #4080
Merged
Bump go to 1.23 #4080
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Michal-Leszczynski
force-pushed
the
ml/bump-go
branch
from
4aadc50 to
c926dcb
Compare
It has support for go 1.23.
It refreshes linter configuration by: - using new config fields - excluding stale linters - excluding 'mnd' (magic number detected) - we can consider to re-enable it in the future - excluding error not checked from CLI
Michal-Leszczynski
force-pushed
the
ml/bump-go
branch
from
44d7f27 to
57e40c1
Compare
|
@karol-kokoszka This PR is ready for review! |
karol-kokoszka
approved these changes
Nov 12, 2024
Yes - bumping versions resulted in many linter errors - I divided linter related changes into commits, so that it's easier to go through them during review. |
Michal-Leszczynski
added a commit
that referenced
this pull request
Dec 10, 2024
* chore(go.mod): bump go to 1.23.2 * feat(install-dependencies): bump golangci-lint to 1.61.0 It has support for go 1.23. * chore(linter): replace unused arguments with _ * chore(linter): update linter spec It refreshes linter configuration by: - using new config fields - excluding stale linters - excluding 'mnd' (magic number detected) - we can consider to re-enable it in the future - excluding error not checked from CLI * chore(linter): use canonical header names * chore(linter): use new for loop syntax * chore(linter): use safe metrics getters * chore(linter): improve string formatting * chore(linter): use named http status codes * chore(linter): name arguments in interfaces * chore(linter): allow for fatcontext in scyllaclient * chore(linter): don't wrap error with no-const string (cherry picked from commit 18103e0)
Michal-Leszczynski
added a commit
that referenced
this pull request
Dec 10, 2024
* chore(go.mod): bump go to 1.23.2 * feat(install-dependencies): bump golangci-lint to 1.61.0 It has support for go 1.23. * chore(linter): replace unused arguments with _ * chore(linter): update linter spec It refreshes linter configuration by: - using new config fields - excluding stale linters - excluding 'mnd' (magic number detected) - we can consider to re-enable it in the future - excluding error not checked from CLI * chore(linter): use canonical header names * chore(linter): use new for loop syntax * chore(linter): use safe metrics getters * chore(linter): improve string formatting * chore(linter): use named http status codes * chore(linter): name arguments in interfaces * chore(linter): allow for fatcontext in scyllaclient * chore(linter): don't wrap error with no-const string (cherry picked from commit 18103e0)
Michal-Leszczynski
added a commit
that referenced
this pull request
Dec 11, 2024
* chore(go.mod): bump go to 1.23.2 * feat(install-dependencies): bump golangci-lint to 1.61.0 It has support for go 1.23. * chore(linter): replace unused arguments with _ * chore(linter): update linter spec It refreshes linter configuration by: - using new config fields - excluding stale linters - excluding 'mnd' (magic number detected) - we can consider to re-enable it in the future - excluding error not checked from CLI * chore(linter): use canonical header names * chore(linter): use new for loop syntax * chore(linter): use safe metrics getters * chore(linter): improve string formatting * chore(linter): use named http status codes * chore(linter): name arguments in interfaces * chore(linter): allow for fatcontext in scyllaclient * chore(linter): don't wrap error with no-const string (cherry picked from commit 18103e0)
Michal-Leszczynski
added a commit
that referenced
this pull request
Dec 11, 2024
* chore(go.mod): bump go to 1.23.2 * feat(install-dependencies): bump golangci-lint to 1.61.0 It has support for go 1.23. * chore(linter): replace unused arguments with _ * chore(linter): update linter spec It refreshes linter configuration by: - using new config fields - excluding stale linters - excluding 'mnd' (magic number detected) - we can consider to re-enable it in the future - excluding error not checked from CLI * chore(linter): use canonical header names * chore(linter): use new for loop syntax * chore(linter): use safe metrics getters * chore(linter): improve string formatting * chore(linter): use named http status codes * chore(linter): name arguments in interfaces * chore(linter): allow for fatcontext in scyllaclient * chore(linter): don't wrap error with no-const string (cherry picked from commit 18103e0)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR bumps go version to 1.23. Among other things, it has support for workspace vendoring. It also bumps golangci-lint to 1.61.0, which has support for go 1.23.